Vendor OpenClaw source as Adolf fork baseline
Some checks failed
ClawSweeper Dispatch / dispatch (push) Has been cancelled
CodeQL / Security High (actions) (push) Has been cancelled
CodeQL / Security High (channel-runtime-boundary) (push) Has been cancelled
CodeQL / Security High (core-auth-secrets) (push) Has been cancelled
CodeQL / Security High (mcp-process-tool-boundary) (push) Has been cancelled
CodeQL / Security High (network-ssrf-boundary) (push) Has been cancelled
CodeQL / Security High (plugin-trust-boundary) (push) Has been cancelled
CodeQL / Security High (process-exec-boundary) (push) Has been cancelled
Docs Sync Publish Repo / sync-publish-repo (push) Has been cancelled
Docs / docs (push) Has been cancelled
OpenClaw Stable Main Closeout / Resolve stable release closeout inputs (push) Has been cancelled
OpenClaw Stable Main Closeout / Verify stable main closeout (push) Has been cancelled
Workflow Sanity / no-tabs (push) Has been cancelled
Workflow Sanity / actionlint (push) Has been cancelled
Workflow Sanity / generated-doc-baselines (push) Has been cancelled
CI / runner-admission (push) Has been cancelled
CI / preflight (push) Has been cancelled
CI / security-fast (push) Has been cancelled
CI / pnpm-store-warmup (push) Has been cancelled
CI / build-artifacts (push) Has been cancelled
CI / native-i18n (push) Has been cancelled
CI / ${{ matrix.check_name }} (push) Has been cancelled
CI / ${{ matrix.checkName }} (push) Has been cancelled
CI / checks-node-compat-node22 (push) Has been cancelled
CI / check-bundled-channel-config-metadata (push) Has been cancelled
CI / check-dependencies (push) Has been cancelled
CI / check-guards (push) Has been cancelled
CI / check-lint (push) Has been cancelled
CI / check-prod-types (push) Has been cancelled
CI / check-shrinkwrap (push) Has been cancelled
CI / check-test-types (push) Has been cancelled
CI / check-additional-boundaries-a (push) Has been cancelled
CI / check-additional-boundaries-bcd (push) Has been cancelled
CI / check-additional-extension-bundled (push) Has been cancelled
CI / check-additional-extension-channels (push) Has been cancelled
CI / check-additional-extension-package-boundary (push) Has been cancelled
CI / check-additional-runtime-topology-architecture (push) Has been cancelled
CI / check-session-accessor-boundary (push) Has been cancelled
CI / check-session-transcript-reader-boundary (push) Has been cancelled
CI / check-docs (push) Has been cancelled
CI / skills-python (push) Has been cancelled
CI / macos-swift (push) Has been cancelled
CI / ios-build (push) Has been cancelled
CI / ci-timings-summary (push) Has been cancelled
Native App Locale Refresh / Refresh native fa (push) Has been cancelled
Native App Locale Refresh / Refresh native fr (push) Has been cancelled
Native App Locale Refresh / Refresh native hi (push) Has been cancelled
Native App Locale Refresh / Refresh native id (push) Has been cancelled
Native App Locale Refresh / Refresh native it (push) Has been cancelled
Native App Locale Refresh / Refresh native ja-JP (push) Has been cancelled
Control UI Locale Refresh / plan (push) Has been cancelled
Control UI Locale Refresh / Refresh ${{ matrix.locale }} (push) Has been cancelled
Control UI Locale Refresh / Commit control UI locale refresh (push) Has been cancelled
Live Media Runner Image / Build live media runner image (push) Has been cancelled
Native App Locale Refresh / Refresh native ar (push) Has been cancelled
Native App Locale Refresh / Refresh native de (push) Has been cancelled
Native App Locale Refresh / Refresh native es (push) Has been cancelled
Native App Locale Refresh / Refresh native ko (push) Has been cancelled
Native App Locale Refresh / Refresh native nl (push) Has been cancelled
Native App Locale Refresh / Refresh native pl (push) Has been cancelled
Native App Locale Refresh / Refresh native pt-BR (push) Has been cancelled
Native App Locale Refresh / Refresh native ru (push) Has been cancelled
Native App Locale Refresh / Refresh native sv (push) Has been cancelled
Native App Locale Refresh / Refresh native th (push) Has been cancelled
Native App Locale Refresh / Refresh native tr (push) Has been cancelled
Native App Locale Refresh / Refresh native uk (push) Has been cancelled
Native App Locale Refresh / Refresh native vi (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-CN (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-TW (push) Has been cancelled
Native App Locale Refresh / Commit native locale refresh (push) Has been cancelled
Plugin Init Scaffold Validation / Validate provider scaffold (push) Has been cancelled
Plugin NPM Release / preview_plugins_npm (push) Has been cancelled
Plugin NPM Release / Validate release publish approval (push) Has been cancelled
Plugin NPM Release / preview_plugin_pack (push) Has been cancelled
Plugin NPM Release / publish_plugins_npm (push) Has been cancelled
Sandbox Common Smoke / sandbox-common-smoke (push) Has been cancelled
Website Installer Sync / static (push) Has been cancelled
Website Installer Sync / linux-docker (push) Has been cancelled
Website Installer Sync / macos-installer (push) Has been cancelled
Website Installer Sync / windows-installer (push) Has been cancelled
Website Installer Sync / sync-website (push) Has been cancelled
Some checks failed
ClawSweeper Dispatch / dispatch (push) Has been cancelled
CodeQL / Security High (actions) (push) Has been cancelled
CodeQL / Security High (channel-runtime-boundary) (push) Has been cancelled
CodeQL / Security High (core-auth-secrets) (push) Has been cancelled
CodeQL / Security High (mcp-process-tool-boundary) (push) Has been cancelled
CodeQL / Security High (network-ssrf-boundary) (push) Has been cancelled
CodeQL / Security High (plugin-trust-boundary) (push) Has been cancelled
CodeQL / Security High (process-exec-boundary) (push) Has been cancelled
Docs Sync Publish Repo / sync-publish-repo (push) Has been cancelled
Docs / docs (push) Has been cancelled
OpenClaw Stable Main Closeout / Resolve stable release closeout inputs (push) Has been cancelled
OpenClaw Stable Main Closeout / Verify stable main closeout (push) Has been cancelled
Workflow Sanity / no-tabs (push) Has been cancelled
Workflow Sanity / actionlint (push) Has been cancelled
Workflow Sanity / generated-doc-baselines (push) Has been cancelled
CI / runner-admission (push) Has been cancelled
CI / preflight (push) Has been cancelled
CI / security-fast (push) Has been cancelled
CI / pnpm-store-warmup (push) Has been cancelled
CI / build-artifacts (push) Has been cancelled
CI / native-i18n (push) Has been cancelled
CI / ${{ matrix.check_name }} (push) Has been cancelled
CI / ${{ matrix.checkName }} (push) Has been cancelled
CI / checks-node-compat-node22 (push) Has been cancelled
CI / check-bundled-channel-config-metadata (push) Has been cancelled
CI / check-dependencies (push) Has been cancelled
CI / check-guards (push) Has been cancelled
CI / check-lint (push) Has been cancelled
CI / check-prod-types (push) Has been cancelled
CI / check-shrinkwrap (push) Has been cancelled
CI / check-test-types (push) Has been cancelled
CI / check-additional-boundaries-a (push) Has been cancelled
CI / check-additional-boundaries-bcd (push) Has been cancelled
CI / check-additional-extension-bundled (push) Has been cancelled
CI / check-additional-extension-channels (push) Has been cancelled
CI / check-additional-extension-package-boundary (push) Has been cancelled
CI / check-additional-runtime-topology-architecture (push) Has been cancelled
CI / check-session-accessor-boundary (push) Has been cancelled
CI / check-session-transcript-reader-boundary (push) Has been cancelled
CI / check-docs (push) Has been cancelled
CI / skills-python (push) Has been cancelled
CI / macos-swift (push) Has been cancelled
CI / ios-build (push) Has been cancelled
CI / ci-timings-summary (push) Has been cancelled
Native App Locale Refresh / Refresh native fa (push) Has been cancelled
Native App Locale Refresh / Refresh native fr (push) Has been cancelled
Native App Locale Refresh / Refresh native hi (push) Has been cancelled
Native App Locale Refresh / Refresh native id (push) Has been cancelled
Native App Locale Refresh / Refresh native it (push) Has been cancelled
Native App Locale Refresh / Refresh native ja-JP (push) Has been cancelled
Control UI Locale Refresh / plan (push) Has been cancelled
Control UI Locale Refresh / Refresh ${{ matrix.locale }} (push) Has been cancelled
Control UI Locale Refresh / Commit control UI locale refresh (push) Has been cancelled
Live Media Runner Image / Build live media runner image (push) Has been cancelled
Native App Locale Refresh / Refresh native ar (push) Has been cancelled
Native App Locale Refresh / Refresh native de (push) Has been cancelled
Native App Locale Refresh / Refresh native es (push) Has been cancelled
Native App Locale Refresh / Refresh native ko (push) Has been cancelled
Native App Locale Refresh / Refresh native nl (push) Has been cancelled
Native App Locale Refresh / Refresh native pl (push) Has been cancelled
Native App Locale Refresh / Refresh native pt-BR (push) Has been cancelled
Native App Locale Refresh / Refresh native ru (push) Has been cancelled
Native App Locale Refresh / Refresh native sv (push) Has been cancelled
Native App Locale Refresh / Refresh native th (push) Has been cancelled
Native App Locale Refresh / Refresh native tr (push) Has been cancelled
Native App Locale Refresh / Refresh native uk (push) Has been cancelled
Native App Locale Refresh / Refresh native vi (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-CN (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-TW (push) Has been cancelled
Native App Locale Refresh / Commit native locale refresh (push) Has been cancelled
Plugin Init Scaffold Validation / Validate provider scaffold (push) Has been cancelled
Plugin NPM Release / preview_plugins_npm (push) Has been cancelled
Plugin NPM Release / Validate release publish approval (push) Has been cancelled
Plugin NPM Release / preview_plugin_pack (push) Has been cancelled
Plugin NPM Release / publish_plugins_npm (push) Has been cancelled
Sandbox Common Smoke / sandbox-common-smoke (push) Has been cancelled
Website Installer Sync / static (push) Has been cancelled
Website Installer Sync / linux-docker (push) Has been cancelled
Website Installer Sync / macos-installer (push) Has been cancelled
Website Installer Sync / windows-installer (push) Has been cancelled
Website Installer Sync / sync-website (push) Has been cancelled
Adolf is a fork/vendored clone of github.com/openclaw/openclaw (v2026.6.11), free to diverge. Tree copied sans upstream .git; upstream remote added for future syncs. Node pinned to 24 (.nvmrc); engines already require >=22.19. Preserves docs/ARCHITECTURE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeqyaxJF2nbRXJtae2kNB2
This commit is contained in:
314
extensions/irc/src/inbound.behavior.test.ts
Normal file
314
extensions/irc/src/inbound.behavior.test.ts
Normal file
@@ -0,0 +1,314 @@
|
||||
// Irc tests cover inbound.behavior plugin behavior.
|
||||
import { createPluginRuntimeMock } from "openclaw/plugin-sdk/channel-test-helpers";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import type { ResolvedIrcAccount } from "./accounts.js";
|
||||
import { handleIrcInbound } from "./inbound.js";
|
||||
import type { RuntimeEnv } from "./runtime-api.js";
|
||||
import { clearIrcRuntime, setIrcRuntime } from "./runtime.js";
|
||||
import type { CoreConfig, IrcInboundMessage } from "./types.js";
|
||||
|
||||
const {
|
||||
buildMentionRegexesMock,
|
||||
hasControlCommandMock,
|
||||
matchesMentionPatternsMock,
|
||||
readAllowFromStoreMock,
|
||||
shouldHandleTextCommandsMock,
|
||||
upsertPairingRequestMock,
|
||||
} = vi.hoisted(() => {
|
||||
return {
|
||||
buildMentionRegexesMock: vi.fn(() => []),
|
||||
hasControlCommandMock: vi.fn(() => false),
|
||||
matchesMentionPatternsMock: vi.fn(() => false),
|
||||
readAllowFromStoreMock: vi.fn(async () => []),
|
||||
shouldHandleTextCommandsMock: vi.fn(() => false),
|
||||
upsertPairingRequestMock: vi.fn(async () => ({ code: "CODE", created: true })),
|
||||
};
|
||||
});
|
||||
|
||||
function installIrcRuntime() {
|
||||
setIrcRuntime({
|
||||
channel: {
|
||||
pairing: {
|
||||
readAllowFromStore: readAllowFromStoreMock,
|
||||
upsertPairingRequest: upsertPairingRequestMock,
|
||||
},
|
||||
commands: {
|
||||
shouldHandleTextCommands: shouldHandleTextCommandsMock,
|
||||
},
|
||||
text: {
|
||||
hasControlCommand: hasControlCommandMock,
|
||||
},
|
||||
mentions: {
|
||||
buildMentionRegexes: buildMentionRegexesMock,
|
||||
matchesMentionPatterns: matchesMentionPatternsMock,
|
||||
},
|
||||
},
|
||||
} as never);
|
||||
}
|
||||
|
||||
function createRuntimeEnv() {
|
||||
return {
|
||||
log: vi.fn(),
|
||||
error: vi.fn(),
|
||||
} as unknown as RuntimeEnv;
|
||||
}
|
||||
|
||||
function createAccount(overrides?: Partial<ResolvedIrcAccount>): ResolvedIrcAccount {
|
||||
return {
|
||||
accountId: "default",
|
||||
enabled: true,
|
||||
server: "irc.example.com",
|
||||
nick: "OpenClaw",
|
||||
config: {
|
||||
dmPolicy: "pairing",
|
||||
allowFrom: [],
|
||||
groupPolicy: "allowlist",
|
||||
groupAllowFrom: [],
|
||||
},
|
||||
...overrides,
|
||||
} as ResolvedIrcAccount;
|
||||
}
|
||||
|
||||
function createMessage(overrides?: Partial<IrcInboundMessage>): IrcInboundMessage {
|
||||
return {
|
||||
messageId: "msg-1",
|
||||
target: "alice",
|
||||
senderNick: "alice",
|
||||
senderUser: "ident",
|
||||
senderHost: "example.com",
|
||||
text: "hello",
|
||||
timestamp: Date.now(),
|
||||
isGroup: false,
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
function resetInboundMocks() {
|
||||
buildMentionRegexesMock.mockReset().mockReturnValue([]);
|
||||
hasControlCommandMock.mockReset().mockReturnValue(false);
|
||||
matchesMentionPatternsMock.mockReset().mockReturnValue(false);
|
||||
readAllowFromStoreMock.mockReset().mockResolvedValue([]);
|
||||
shouldHandleTextCommandsMock.mockReset().mockReturnValue(false);
|
||||
upsertPairingRequestMock.mockReset().mockResolvedValue({ code: "CODE", created: true });
|
||||
}
|
||||
|
||||
describe("irc inbound behavior", () => {
|
||||
beforeEach(() => {
|
||||
resetInboundMocks();
|
||||
installIrcRuntime();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
clearIrcRuntime();
|
||||
});
|
||||
|
||||
it("issues a DM pairing challenge and sends the reply to the sender nick", async () => {
|
||||
const sendReply = vi.fn<(target: string, text: string, replyToId?: string) => Promise<void>>(
|
||||
async () => {},
|
||||
);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage(),
|
||||
account: createAccount(),
|
||||
config: { channels: { irc: {} } } as CoreConfig,
|
||||
runtime: createRuntimeEnv(),
|
||||
sendReply,
|
||||
});
|
||||
|
||||
expect(upsertPairingRequestMock).toHaveBeenCalledWith({
|
||||
channel: "irc",
|
||||
accountId: "default",
|
||||
id: "alice!ident@example.com",
|
||||
meta: { name: "alice" },
|
||||
});
|
||||
expect(sendReply).toHaveBeenCalledTimes(1);
|
||||
expect(sendReply).toHaveBeenCalledWith(
|
||||
"alice",
|
||||
[
|
||||
"OpenClaw: access not configured.",
|
||||
"",
|
||||
"Your IRC id: alice!ident@example.com",
|
||||
"Pairing code:",
|
||||
"```",
|
||||
"CODE",
|
||||
"```",
|
||||
"",
|
||||
"Ask the bot owner to approve with:",
|
||||
"```",
|
||||
"openclaw pairing approve irc CODE",
|
||||
"```",
|
||||
].join("\n"),
|
||||
undefined,
|
||||
);
|
||||
});
|
||||
|
||||
it("drops unauthorized group control commands before dispatch", async () => {
|
||||
const runtime = createRuntimeEnv();
|
||||
shouldHandleTextCommandsMock.mockReturnValue(true);
|
||||
hasControlCommandMock.mockReturnValue(true);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage({
|
||||
target: "#ops",
|
||||
isGroup: true,
|
||||
text: "/admin",
|
||||
}),
|
||||
account: createAccount({
|
||||
config: {
|
||||
dmPolicy: "pairing",
|
||||
allowFrom: [],
|
||||
groupPolicy: "allowlist",
|
||||
groupAllowFrom: ["bob!ident@example.com"],
|
||||
groups: {
|
||||
"#ops": {
|
||||
allowFrom: ["alice!ident@example.com"],
|
||||
},
|
||||
},
|
||||
},
|
||||
}),
|
||||
config: { channels: { irc: {} }, commands: { useAccessGroups: true } } as CoreConfig,
|
||||
runtime,
|
||||
});
|
||||
|
||||
expect(runtime.log).toHaveBeenCalledWith(
|
||||
"irc: drop control command (unauthorized) target=alice!ident@example.com",
|
||||
);
|
||||
});
|
||||
|
||||
it("passes the shared reply pipeline for dispatched replies", async () => {
|
||||
const coreRuntime = createPluginRuntimeMock();
|
||||
setIrcRuntime(coreRuntime as never);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage(),
|
||||
account: createAccount({
|
||||
config: {
|
||||
dmPolicy: "open",
|
||||
allowFrom: ["*"],
|
||||
groupPolicy: "allowlist",
|
||||
groupAllowFrom: [],
|
||||
},
|
||||
}),
|
||||
config: { channels: { irc: {} } } as CoreConfig,
|
||||
runtime: createRuntimeEnv(),
|
||||
sendReply: vi.fn(async () => {}),
|
||||
});
|
||||
|
||||
const assembledRequest = (
|
||||
coreRuntime.channel.inbound.dispatchReply as unknown as { mock: { calls: unknown[][] } }
|
||||
).mock.calls[0]?.[0] as { replyPipeline?: unknown } | undefined;
|
||||
expect(assembledRequest?.replyPipeline).toEqual({});
|
||||
});
|
||||
|
||||
it("uses channel:# prefix for group channel From and OriginatingTo fields", async () => {
|
||||
const coreRuntime = createPluginRuntimeMock();
|
||||
const runtime = createRuntimeEnv();
|
||||
setIrcRuntime(coreRuntime as never);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage({
|
||||
target: "#ops",
|
||||
isGroup: true,
|
||||
senderNick: "alice",
|
||||
senderUser: "ident",
|
||||
senderHost: "example.com",
|
||||
text: "hello",
|
||||
}),
|
||||
account: createAccount({
|
||||
config: {
|
||||
dmPolicy: "open",
|
||||
allowFrom: ["*"],
|
||||
groupPolicy: "open",
|
||||
groupAllowFrom: [],
|
||||
groups: {
|
||||
"#ops": { enabled: true, requireMention: false },
|
||||
},
|
||||
},
|
||||
}),
|
||||
config: { channels: { irc: {} } } as CoreConfig,
|
||||
runtime,
|
||||
sendReply: vi.fn(async () => {}),
|
||||
});
|
||||
|
||||
const ctx = (
|
||||
coreRuntime.channel.reply.finalizeInboundContext as unknown as {
|
||||
mock: { calls: unknown[][] };
|
||||
}
|
||||
).mock.calls[0]?.[0] as Record<string, unknown> | undefined;
|
||||
expect(
|
||||
(coreRuntime.channel.inbound.dispatchReply as unknown as { mock: { calls: unknown[][] } })
|
||||
.mock.calls.length,
|
||||
).toBe(1);
|
||||
expect(runtime.log).not.toHaveBeenCalled();
|
||||
expect(ctx?.From).toBe("channel:#ops");
|
||||
expect(ctx?.To).toBe("channel:#ops");
|
||||
expect(ctx?.OriginatingTo).toBe("channel:#ops");
|
||||
});
|
||||
|
||||
it("drops a spoofed sender for a host-less nick!user DM allowlist entry", async () => {
|
||||
const coreRuntime = createPluginRuntimeMock();
|
||||
const runtime = createRuntimeEnv();
|
||||
setIrcRuntime(coreRuntime as never);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage({
|
||||
target: "alice",
|
||||
senderNick: "alice",
|
||||
senderUser: "ident",
|
||||
senderHost: "attacker.example",
|
||||
text: "hello",
|
||||
}),
|
||||
account: createAccount({
|
||||
config: {
|
||||
dmPolicy: "allowlist",
|
||||
allowFrom: ["alice!ident"],
|
||||
groupPolicy: "allowlist",
|
||||
groupAllowFrom: [],
|
||||
},
|
||||
}),
|
||||
config: { channels: { irc: {} } } as CoreConfig,
|
||||
runtime,
|
||||
sendReply: vi.fn(async () => {}),
|
||||
});
|
||||
|
||||
expect(
|
||||
(coreRuntime.channel.inbound.dispatchReply as unknown as { mock: { calls: unknown[][] } })
|
||||
.mock.calls.length,
|
||||
).toBe(0);
|
||||
expect(runtime.log).toHaveBeenCalledWith(
|
||||
"irc: drop DM sender alice!ident@attacker.example (dmPolicy=allowlist)",
|
||||
);
|
||||
});
|
||||
|
||||
it("admits a sender matching a full nick!user@host DM allowlist entry", async () => {
|
||||
const coreRuntime = createPluginRuntimeMock();
|
||||
const runtime = createRuntimeEnv();
|
||||
setIrcRuntime(coreRuntime as never);
|
||||
|
||||
await handleIrcInbound({
|
||||
message: createMessage({
|
||||
target: "alice",
|
||||
senderNick: "alice",
|
||||
senderUser: "ident",
|
||||
senderHost: "example.com",
|
||||
text: "hello",
|
||||
}),
|
||||
account: createAccount({
|
||||
config: {
|
||||
dmPolicy: "allowlist",
|
||||
allowFrom: ["alice!ident@example.com"],
|
||||
groupPolicy: "allowlist",
|
||||
groupAllowFrom: [],
|
||||
},
|
||||
}),
|
||||
config: { channels: { irc: {} } } as CoreConfig,
|
||||
runtime,
|
||||
sendReply: vi.fn(async () => {}),
|
||||
});
|
||||
|
||||
expect(
|
||||
(coreRuntime.channel.inbound.dispatchReply as unknown as { mock: { calls: unknown[][] } })
|
||||
.mock.calls.length,
|
||||
).toBe(1);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user