Some checks failed
ClawSweeper Dispatch / dispatch (push) Has been cancelled
CodeQL / Security High (actions) (push) Has been cancelled
CodeQL / Security High (channel-runtime-boundary) (push) Has been cancelled
CodeQL / Security High (core-auth-secrets) (push) Has been cancelled
CodeQL / Security High (mcp-process-tool-boundary) (push) Has been cancelled
CodeQL / Security High (network-ssrf-boundary) (push) Has been cancelled
CodeQL / Security High (plugin-trust-boundary) (push) Has been cancelled
CodeQL / Security High (process-exec-boundary) (push) Has been cancelled
Docs Sync Publish Repo / sync-publish-repo (push) Has been cancelled
Docs / docs (push) Has been cancelled
OpenClaw Stable Main Closeout / Resolve stable release closeout inputs (push) Has been cancelled
OpenClaw Stable Main Closeout / Verify stable main closeout (push) Has been cancelled
Workflow Sanity / no-tabs (push) Has been cancelled
Workflow Sanity / actionlint (push) Has been cancelled
Workflow Sanity / generated-doc-baselines (push) Has been cancelled
CI / runner-admission (push) Has been cancelled
CI / preflight (push) Has been cancelled
CI / security-fast (push) Has been cancelled
CI / pnpm-store-warmup (push) Has been cancelled
CI / build-artifacts (push) Has been cancelled
CI / native-i18n (push) Has been cancelled
CI / ${{ matrix.check_name }} (push) Has been cancelled
CI / ${{ matrix.checkName }} (push) Has been cancelled
CI / checks-node-compat-node22 (push) Has been cancelled
CI / check-bundled-channel-config-metadata (push) Has been cancelled
CI / check-dependencies (push) Has been cancelled
CI / check-guards (push) Has been cancelled
CI / check-lint (push) Has been cancelled
CI / check-prod-types (push) Has been cancelled
CI / check-shrinkwrap (push) Has been cancelled
CI / check-test-types (push) Has been cancelled
CI / check-additional-boundaries-a (push) Has been cancelled
CI / check-additional-boundaries-bcd (push) Has been cancelled
CI / check-additional-extension-bundled (push) Has been cancelled
CI / check-additional-extension-channels (push) Has been cancelled
CI / check-additional-extension-package-boundary (push) Has been cancelled
CI / check-additional-runtime-topology-architecture (push) Has been cancelled
CI / check-session-accessor-boundary (push) Has been cancelled
CI / check-session-transcript-reader-boundary (push) Has been cancelled
CI / check-docs (push) Has been cancelled
CI / skills-python (push) Has been cancelled
CI / macos-swift (push) Has been cancelled
CI / ios-build (push) Has been cancelled
CI / ci-timings-summary (push) Has been cancelled
Native App Locale Refresh / Refresh native fa (push) Has been cancelled
Native App Locale Refresh / Refresh native fr (push) Has been cancelled
Native App Locale Refresh / Refresh native hi (push) Has been cancelled
Native App Locale Refresh / Refresh native id (push) Has been cancelled
Native App Locale Refresh / Refresh native it (push) Has been cancelled
Native App Locale Refresh / Refresh native ja-JP (push) Has been cancelled
Control UI Locale Refresh / plan (push) Has been cancelled
Control UI Locale Refresh / Refresh ${{ matrix.locale }} (push) Has been cancelled
Control UI Locale Refresh / Commit control UI locale refresh (push) Has been cancelled
Live Media Runner Image / Build live media runner image (push) Has been cancelled
Native App Locale Refresh / Refresh native ar (push) Has been cancelled
Native App Locale Refresh / Refresh native de (push) Has been cancelled
Native App Locale Refresh / Refresh native es (push) Has been cancelled
Native App Locale Refresh / Refresh native ko (push) Has been cancelled
Native App Locale Refresh / Refresh native nl (push) Has been cancelled
Native App Locale Refresh / Refresh native pl (push) Has been cancelled
Native App Locale Refresh / Refresh native pt-BR (push) Has been cancelled
Native App Locale Refresh / Refresh native ru (push) Has been cancelled
Native App Locale Refresh / Refresh native sv (push) Has been cancelled
Native App Locale Refresh / Refresh native th (push) Has been cancelled
Native App Locale Refresh / Refresh native tr (push) Has been cancelled
Native App Locale Refresh / Refresh native uk (push) Has been cancelled
Native App Locale Refresh / Refresh native vi (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-CN (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-TW (push) Has been cancelled
Native App Locale Refresh / Commit native locale refresh (push) Has been cancelled
Plugin Init Scaffold Validation / Validate provider scaffold (push) Has been cancelled
Plugin NPM Release / preview_plugins_npm (push) Has been cancelled
Plugin NPM Release / Validate release publish approval (push) Has been cancelled
Plugin NPM Release / preview_plugin_pack (push) Has been cancelled
Plugin NPM Release / publish_plugins_npm (push) Has been cancelled
Sandbox Common Smoke / sandbox-common-smoke (push) Has been cancelled
Website Installer Sync / static (push) Has been cancelled
Website Installer Sync / linux-docker (push) Has been cancelled
Website Installer Sync / macos-installer (push) Has been cancelled
Website Installer Sync / windows-installer (push) Has been cancelled
Website Installer Sync / sync-website (push) Has been cancelled
Adolf is a fork/vendored clone of github.com/openclaw/openclaw (v2026.6.11), free to diverge. Tree copied sans upstream .git; upstream remote added for future syncs. Node pinned to 24 (.nvmrc); engines already require >=22.19. Preserves docs/ARCHITECTURE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeqyaxJF2nbRXJtae2kNB2
143 lines
4.5 KiB
JavaScript
143 lines
4.5 KiB
JavaScript
import { once } from "node:events";
|
||
// Proof script: verifies readResponseWithLimit stops Telegram Bot API response reads at the cap.
|
||
import { createServer } from "node:http";
|
||
import { resolve } from "node:path";
|
||
|
||
const pkgRoot = resolve(import.meta.dirname, "..");
|
||
|
||
const { readResponseWithLimit } = await import(`${pkgRoot}/src/infra/http-body.ts`).catch(
|
||
() => import("openclaw/plugin-sdk/response-limit-runtime"),
|
||
);
|
||
|
||
const CAP = 1 * 1024 * 1024; // 1 MiB proof cap
|
||
const STREAM_SIZE = 24 * 1024 * 1024; // 24 MiB – simulates hostile oversized Bot API response
|
||
|
||
let allPassed = true;
|
||
function check(label, val) {
|
||
console.log(` ${val ? "ok" : "FAIL"}: ${label}`);
|
||
if (!val) {
|
||
allPassed = false;
|
||
}
|
||
}
|
||
|
||
// Server-side byte counter: track how many response bytes were actually written to the socket.
|
||
let serverBytesWritten = 0;
|
||
|
||
async function withServer(fn) {
|
||
serverBytesWritten = 0;
|
||
const server = createServer((req, res) => {
|
||
if (req.url === "/huge") {
|
||
res.writeHead(200, { "Content-Type": "application/json" });
|
||
const chunk = Buffer.alloc(65536, 120); // 64 KiB of 'x'
|
||
const header = Buffer.from('{"ok":true,"result":[');
|
||
res.write(header);
|
||
serverBytesWritten += header.length;
|
||
|
||
let sent = header.length;
|
||
const writeNext = () => {
|
||
if (sent >= STREAM_SIZE) {
|
||
const tail = Buffer.from("]}");
|
||
res.write(tail);
|
||
serverBytesWritten += tail.length;
|
||
res.end();
|
||
return;
|
||
}
|
||
const ok = res.write(chunk);
|
||
serverBytesWritten += chunk.length;
|
||
sent += chunk.length;
|
||
if (ok) {
|
||
setImmediate(writeNext);
|
||
} else {
|
||
res.once("drain", writeNext);
|
||
}
|
||
};
|
||
writeNext();
|
||
} else {
|
||
const body = JSON.stringify({
|
||
ok: true,
|
||
result: {
|
||
id: 123456789,
|
||
is_bot: true,
|
||
username: "my_test_bot",
|
||
first_name: "TestBot",
|
||
},
|
||
});
|
||
res.writeHead(200, {
|
||
"Content-Type": "application/json",
|
||
"Content-Length": String(Buffer.byteLength(body)),
|
||
});
|
||
res.end(body);
|
||
serverBytesWritten += Buffer.byteLength(body);
|
||
}
|
||
});
|
||
server.listen(0, "127.0.0.1");
|
||
await once(server, "listening");
|
||
const { port } = server.address();
|
||
try {
|
||
await fn(port, server);
|
||
} finally {
|
||
await new Promise((resolveDone) => {
|
||
server.close(resolveDone);
|
||
});
|
||
}
|
||
}
|
||
|
||
console.log(`\n[proof] Telegram Bot API response-limit`);
|
||
console.log(` cap=${CAP} bytes (1 MiB), would-stream≈${STREAM_SIZE} bytes (24 MiB)\n`);
|
||
|
||
// ── Case 1: readResponseWithLimit rejects oversized body ─────────────────────
|
||
await withServer(async (port) => {
|
||
serverBytesWritten = 0;
|
||
const res = await fetch(`http://127.0.0.1:${port}/huge`);
|
||
let err;
|
||
try {
|
||
await readResponseWithLimit(res, CAP);
|
||
} catch (e) {
|
||
err = e;
|
||
}
|
||
// Give server a tick to flush its internal counter before checking
|
||
await new Promise((done) => {
|
||
setTimeout(done, 50);
|
||
});
|
||
const sent = serverBytesWritten;
|
||
check(`oversized body rejected (threw=${err != null})`, err != null);
|
||
check(
|
||
`error message contains limit info: "${err?.message?.slice(0, 80)}"`,
|
||
err?.message?.includes("limit") === true,
|
||
);
|
||
check(
|
||
`server wrote ≈${sent} bytes, well below 24 MiB (stream was cancelled early)`,
|
||
sent < STREAM_SIZE * 0.1,
|
||
);
|
||
});
|
||
|
||
// ── Negative control: unbounded .json() reads the FULL 24 MiB ────────────────
|
||
await withServer(async (port) => {
|
||
serverBytesWritten = 0;
|
||
const res2 = await fetch(`http://127.0.0.1:${port}/huge`);
|
||
await res2.json().catch(() => undefined);
|
||
await new Promise((done) => {
|
||
setTimeout(done, 50);
|
||
});
|
||
const sent2 = serverBytesWritten;
|
||
check(
|
||
`negative control: unbounded .json() caused server to write ≈${sent2} bytes (>> ${CAP})`,
|
||
sent2 > CAP,
|
||
);
|
||
});
|
||
|
||
// ── Case 3: small happy-path response (like real getMe / getUpdates OK) ───────
|
||
await withServer(async (port) => {
|
||
const res3 = await fetch(`http://127.0.0.1:${port}/small`);
|
||
const buf = await readResponseWithLimit(res3, CAP);
|
||
const parsed = JSON.parse(buf.toString("utf8"));
|
||
check(
|
||
`small response parsed correctly (ok=${parsed?.ok} id=${parsed?.result?.id})`,
|
||
parsed?.ok === true && parsed?.result?.id === 123456789,
|
||
);
|
||
check(`result bytes within cap (${buf.length} < ${CAP})`, buf.length > 0 && buf.length < CAP);
|
||
});
|
||
|
||
console.log(allPassed ? "\nALL PROOF ASSERTIONS PASSED" : "\nSOME ASSERTIONS FAILED");
|
||
process.exit(allPassed ? 0 : 1);
|