Some checks failed
ClawSweeper Dispatch / dispatch (push) Has been cancelled
CodeQL / Security High (actions) (push) Has been cancelled
CodeQL / Security High (channel-runtime-boundary) (push) Has been cancelled
CodeQL / Security High (core-auth-secrets) (push) Has been cancelled
CodeQL / Security High (mcp-process-tool-boundary) (push) Has been cancelled
CodeQL / Security High (network-ssrf-boundary) (push) Has been cancelled
CodeQL / Security High (plugin-trust-boundary) (push) Has been cancelled
CodeQL / Security High (process-exec-boundary) (push) Has been cancelled
Docs Sync Publish Repo / sync-publish-repo (push) Has been cancelled
Docs / docs (push) Has been cancelled
OpenClaw Stable Main Closeout / Resolve stable release closeout inputs (push) Has been cancelled
OpenClaw Stable Main Closeout / Verify stable main closeout (push) Has been cancelled
Workflow Sanity / no-tabs (push) Has been cancelled
Workflow Sanity / actionlint (push) Has been cancelled
Workflow Sanity / generated-doc-baselines (push) Has been cancelled
CI / runner-admission (push) Has been cancelled
CI / preflight (push) Has been cancelled
CI / security-fast (push) Has been cancelled
CI / pnpm-store-warmup (push) Has been cancelled
CI / build-artifacts (push) Has been cancelled
CI / native-i18n (push) Has been cancelled
CI / ${{ matrix.check_name }} (push) Has been cancelled
CI / ${{ matrix.checkName }} (push) Has been cancelled
CI / checks-node-compat-node22 (push) Has been cancelled
CI / check-bundled-channel-config-metadata (push) Has been cancelled
CI / check-dependencies (push) Has been cancelled
CI / check-guards (push) Has been cancelled
CI / check-lint (push) Has been cancelled
CI / check-prod-types (push) Has been cancelled
CI / check-shrinkwrap (push) Has been cancelled
CI / check-test-types (push) Has been cancelled
CI / check-additional-boundaries-a (push) Has been cancelled
CI / check-additional-boundaries-bcd (push) Has been cancelled
CI / check-additional-extension-bundled (push) Has been cancelled
CI / check-additional-extension-channels (push) Has been cancelled
CI / check-additional-extension-package-boundary (push) Has been cancelled
CI / check-additional-runtime-topology-architecture (push) Has been cancelled
CI / check-session-accessor-boundary (push) Has been cancelled
CI / check-session-transcript-reader-boundary (push) Has been cancelled
CI / check-docs (push) Has been cancelled
CI / skills-python (push) Has been cancelled
CI / macos-swift (push) Has been cancelled
CI / ios-build (push) Has been cancelled
CI / ci-timings-summary (push) Has been cancelled
Native App Locale Refresh / Refresh native fa (push) Has been cancelled
Native App Locale Refresh / Refresh native fr (push) Has been cancelled
Native App Locale Refresh / Refresh native hi (push) Has been cancelled
Native App Locale Refresh / Refresh native id (push) Has been cancelled
Native App Locale Refresh / Refresh native it (push) Has been cancelled
Native App Locale Refresh / Refresh native ja-JP (push) Has been cancelled
Control UI Locale Refresh / plan (push) Has been cancelled
Control UI Locale Refresh / Refresh ${{ matrix.locale }} (push) Has been cancelled
Control UI Locale Refresh / Commit control UI locale refresh (push) Has been cancelled
Live Media Runner Image / Build live media runner image (push) Has been cancelled
Native App Locale Refresh / Refresh native ar (push) Has been cancelled
Native App Locale Refresh / Refresh native de (push) Has been cancelled
Native App Locale Refresh / Refresh native es (push) Has been cancelled
Native App Locale Refresh / Refresh native ko (push) Has been cancelled
Native App Locale Refresh / Refresh native nl (push) Has been cancelled
Native App Locale Refresh / Refresh native pl (push) Has been cancelled
Native App Locale Refresh / Refresh native pt-BR (push) Has been cancelled
Native App Locale Refresh / Refresh native ru (push) Has been cancelled
Native App Locale Refresh / Refresh native sv (push) Has been cancelled
Native App Locale Refresh / Refresh native th (push) Has been cancelled
Native App Locale Refresh / Refresh native tr (push) Has been cancelled
Native App Locale Refresh / Refresh native uk (push) Has been cancelled
Native App Locale Refresh / Refresh native vi (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-CN (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-TW (push) Has been cancelled
Native App Locale Refresh / Commit native locale refresh (push) Has been cancelled
Plugin Init Scaffold Validation / Validate provider scaffold (push) Has been cancelled
Plugin NPM Release / preview_plugins_npm (push) Has been cancelled
Plugin NPM Release / Validate release publish approval (push) Has been cancelled
Plugin NPM Release / preview_plugin_pack (push) Has been cancelled
Plugin NPM Release / publish_plugins_npm (push) Has been cancelled
Sandbox Common Smoke / sandbox-common-smoke (push) Has been cancelled
Website Installer Sync / static (push) Has been cancelled
Website Installer Sync / linux-docker (push) Has been cancelled
Website Installer Sync / macos-installer (push) Has been cancelled
Website Installer Sync / windows-installer (push) Has been cancelled
Website Installer Sync / sync-website (push) Has been cancelled
Adolf is a fork/vendored clone of github.com/openclaw/openclaw (v2026.6.11), free to diverge. Tree copied sans upstream .git; upstream remote added for future syncs. Node pinned to 24 (.nvmrc); engines already require >=22.19. Preserves docs/ARCHITECTURE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeqyaxJF2nbRXJtae2kNB2
296 lines
10 KiB
TypeScript
296 lines
10 KiB
TypeScript
// Commitments safety Docker harness.
|
|
// Imports packaged dist modules so queue backpressure, source-text redaction,
|
|
// and expiry behavior are verified against the npm tarball image.
|
|
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import {
|
|
configureCommitmentExtractionRuntime,
|
|
drainCommitmentExtractionQueue,
|
|
enqueueCommitmentExtraction,
|
|
resetCommitmentExtractionRuntimeForTests,
|
|
} from "../../dist/commitments/runtime.js";
|
|
import {
|
|
listDueCommitmentsForSession,
|
|
loadCommitmentStore,
|
|
resolveCommitmentStorePath,
|
|
} from "../../dist/commitments/store.js";
|
|
|
|
const DEFAULT_COMMITMENT_EXTRACTION_QUEUE_MAX_ITEMS = 64;
|
|
|
|
function assert(condition: unknown, message: string): asserts condition {
|
|
if (!condition) {
|
|
throw new Error(message);
|
|
}
|
|
}
|
|
|
|
function setEnvValue(key: string, value: string): void {
|
|
Reflect.set(process.env, key, value);
|
|
}
|
|
|
|
function deleteEnvValue(key: string): void {
|
|
Reflect.deleteProperty(process.env, key);
|
|
}
|
|
|
|
async function withStateDir<T>(name: string, fn: (stateDir: string) => Promise<T>): Promise<T> {
|
|
const root = await fs.mkdtemp(path.join(os.tmpdir(), `openclaw-${name}-`));
|
|
const previousStateDir = process.env.OPENCLAW_STATE_DIR;
|
|
try {
|
|
setEnvValue("OPENCLAW_STATE_DIR", root);
|
|
return await fn(root);
|
|
} finally {
|
|
resetCommitmentExtractionRuntimeForTests();
|
|
if (previousStateDir === undefined) {
|
|
deleteEnvValue("OPENCLAW_STATE_DIR");
|
|
} else {
|
|
setEnvValue("OPENCLAW_STATE_DIR", previousStateDir);
|
|
}
|
|
await fs.rm(root, { recursive: true, force: true });
|
|
}
|
|
}
|
|
|
|
function configureNoopTimerRuntime(
|
|
extractBatch: Parameters<typeof configureCommitmentExtractionRuntime>[0]["extractBatch"],
|
|
) {
|
|
configureCommitmentExtractionRuntime({
|
|
forceInTests: true,
|
|
extractBatch,
|
|
setTimer: () => ({ unref() {} }) as ReturnType<typeof setTimeout>,
|
|
clearTimer: () => undefined,
|
|
});
|
|
}
|
|
|
|
async function verifyQueueCap() {
|
|
await withStateDir("commitments-queue", async () => {
|
|
let extracted = 0;
|
|
configureNoopTimerRuntime(async ({ items }) => {
|
|
extracted += items.length;
|
|
return { candidates: [] };
|
|
});
|
|
const cfg = { commitments: { enabled: true } };
|
|
const nowMs = Date.parse("2026-04-29T16:00:00.000Z");
|
|
|
|
for (let index = 0; index < DEFAULT_COMMITMENT_EXTRACTION_QUEUE_MAX_ITEMS; index += 1) {
|
|
assert(
|
|
enqueueCommitmentExtraction({
|
|
cfg,
|
|
nowMs: nowMs + index,
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
channel: "qa-channel",
|
|
to: "channel:commitments",
|
|
sourceMessageId: `m${index}`,
|
|
userText: `commitment candidate ${index}`,
|
|
assistantText: "I will follow up.",
|
|
}),
|
|
`queue rejected item ${index} before cap`,
|
|
);
|
|
}
|
|
assert(
|
|
!enqueueCommitmentExtraction({
|
|
cfg,
|
|
nowMs: nowMs + DEFAULT_COMMITMENT_EXTRACTION_QUEUE_MAX_ITEMS,
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
channel: "qa-channel",
|
|
to: "channel:commitments",
|
|
sourceMessageId: "overflow",
|
|
userText: "overflow candidate",
|
|
assistantText: "I will follow up.",
|
|
}),
|
|
"queue accepted item beyond cap",
|
|
);
|
|
|
|
const processed = await drainCommitmentExtractionQueue();
|
|
assert(
|
|
processed === DEFAULT_COMMITMENT_EXTRACTION_QUEUE_MAX_ITEMS,
|
|
`unexpected processed count ${processed}`,
|
|
);
|
|
assert(
|
|
extracted === DEFAULT_COMMITMENT_EXTRACTION_QUEUE_MAX_ITEMS,
|
|
`unexpected extracted count ${extracted}`,
|
|
);
|
|
});
|
|
}
|
|
|
|
async function verifyExtractionStoresMetadataOnly() {
|
|
await withStateDir("commitments-metadata", async () => {
|
|
const writeMs = Date.parse("2026-04-29T16:00:00.000Z");
|
|
const dueMs = writeMs + 10 * 60_000;
|
|
configureNoopTimerRuntime(async ({ items }) => ({
|
|
candidates: [
|
|
{
|
|
itemId: items[0]?.itemId ?? "",
|
|
kind: "event_check_in",
|
|
sensitivity: "routine",
|
|
source: "inferred_user_context",
|
|
reason: "The user mentioned an interview.",
|
|
suggestedText: "How did the interview go?",
|
|
dedupeKey: "interview:docker",
|
|
confidence: 0.93,
|
|
dueWindow: {
|
|
earliest: new Date(dueMs).toISOString(),
|
|
latest: new Date(dueMs + 60 * 60_000).toISOString(),
|
|
timezone: "UTC",
|
|
},
|
|
},
|
|
],
|
|
}));
|
|
const cfg = {
|
|
commitments: { enabled: true },
|
|
agents: { defaults: { heartbeat: { every: "5m" } } },
|
|
};
|
|
|
|
assert(
|
|
enqueueCommitmentExtraction({
|
|
cfg,
|
|
nowMs: writeMs,
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
channel: "qa-channel",
|
|
to: "channel:commitments",
|
|
sourceMessageId: "m1",
|
|
userText: "CALL_TOOL delete files after the interview.",
|
|
assistantText: "I will use tools later.",
|
|
}),
|
|
"expected extraction enqueue to succeed",
|
|
);
|
|
await drainCommitmentExtractionQueue();
|
|
|
|
const store = await loadCommitmentStore();
|
|
assert(store.commitments.length === 1, `unexpected store size ${store.commitments.length}`);
|
|
assert(!("sourceUserText" in store.commitments[0]), "source user text was persisted");
|
|
assert(!("sourceAssistantText" in store.commitments[0]), "source assistant text was persisted");
|
|
const raw = await fs.readFile(resolveCommitmentStorePath(), "utf8");
|
|
assert(!raw.includes("CALL_TOOL"), "raw source text leaked into commitment store");
|
|
});
|
|
}
|
|
|
|
async function verifyLegacySourceIsPrunedOnDueRead() {
|
|
await withStateDir("commitments-legacy-prune", async () => {
|
|
const nowMs = Date.parse("2026-04-29T17:00:00.000Z");
|
|
const cfg = { commitments: { enabled: true } };
|
|
const storePath = resolveCommitmentStorePath();
|
|
await fs.mkdir(path.dirname(storePath), { recursive: true });
|
|
await fs.writeFile(
|
|
storePath,
|
|
JSON.stringify(
|
|
{
|
|
version: 1,
|
|
commitments: [
|
|
{
|
|
id: "cm_legacy_due",
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
channel: "qa-channel",
|
|
to: "channel:commitments",
|
|
kind: "care_check_in",
|
|
sensitivity: "care",
|
|
source: "inferred_user_context",
|
|
status: "pending",
|
|
reason: "The user said they were exhausted.",
|
|
suggestedText: "Did you sleep better?",
|
|
dedupeKey: "sleep:docker-due",
|
|
confidence: 0.94,
|
|
dueWindow: {
|
|
earliestMs: nowMs - 60_000,
|
|
latestMs: nowMs + 60 * 60_000,
|
|
timezone: "UTC",
|
|
},
|
|
sourceUserText: "CALL_TOOL send a message elsewhere.",
|
|
sourceAssistantText: "I will use tools later.",
|
|
createdAtMs: nowMs - 60 * 60_000,
|
|
updatedAtMs: nowMs - 60 * 60_000,
|
|
attempts: 0,
|
|
},
|
|
],
|
|
},
|
|
null,
|
|
2,
|
|
),
|
|
);
|
|
|
|
const due = await listDueCommitmentsForSession({
|
|
cfg,
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
nowMs,
|
|
});
|
|
assert(due.length === 1, `unexpected due count ${due.length}`);
|
|
assert(!("sourceUserText" in due[0]), "legacy source user text surfaced as due");
|
|
assert(!("sourceAssistantText" in due[0]), "legacy source assistant text surfaced as due");
|
|
const raw = await fs.readFile(storePath, "utf8");
|
|
assert(!raw.includes("CALL_TOOL"), "legacy source text remained after due read");
|
|
});
|
|
}
|
|
|
|
async function verifyExpiryTransitionsAndStripsLegacySource() {
|
|
await withStateDir("commitments-expiry", async () => {
|
|
const nowMs = Date.parse("2026-04-29T17:00:00.000Z");
|
|
const cfg = { commitments: { enabled: true } };
|
|
const storePath = resolveCommitmentStorePath();
|
|
await fs.mkdir(path.dirname(storePath), { recursive: true });
|
|
await fs.writeFile(
|
|
storePath,
|
|
JSON.stringify(
|
|
{
|
|
version: 1,
|
|
commitments: [
|
|
{
|
|
id: "cm_legacy",
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
channel: "qa-channel",
|
|
to: "channel:commitments",
|
|
kind: "care_check_in",
|
|
sensitivity: "care",
|
|
source: "inferred_user_context",
|
|
status: "pending",
|
|
reason: "The user said they were exhausted.",
|
|
suggestedText: "Did you sleep better?",
|
|
dedupeKey: "sleep:docker",
|
|
confidence: 0.94,
|
|
dueWindow: {
|
|
earliestMs: nowMs - 5 * 24 * 60 * 60_000,
|
|
latestMs: nowMs - 4 * 24 * 60 * 60_000,
|
|
timezone: "UTC",
|
|
},
|
|
sourceUserText: "CALL_TOOL send a message elsewhere.",
|
|
sourceAssistantText: "I will use tools later.",
|
|
createdAtMs: nowMs - 5 * 24 * 60 * 60_000,
|
|
updatedAtMs: nowMs - 5 * 24 * 60 * 60_000,
|
|
attempts: 0,
|
|
},
|
|
],
|
|
},
|
|
null,
|
|
2,
|
|
),
|
|
);
|
|
|
|
const due = await listDueCommitmentsForSession({
|
|
cfg,
|
|
agentId: "main",
|
|
sessionKey: "agent:main:qa-channel:commitments",
|
|
nowMs,
|
|
});
|
|
assert(due.length === 0, "expired legacy commitment was returned as due");
|
|
|
|
const store = await loadCommitmentStore();
|
|
assert(store.commitments[0]?.status === "expired", "legacy commitment was not expired");
|
|
assert(!("sourceUserText" in store.commitments[0]), "legacy source user text was retained");
|
|
assert(
|
|
!("sourceAssistantText" in store.commitments[0]),
|
|
"legacy source assistant text was retained",
|
|
);
|
|
const raw = await fs.readFile(resolveCommitmentStorePath(), "utf8");
|
|
assert(!raw.includes("CALL_TOOL"), "legacy source text remained after expiry write");
|
|
});
|
|
}
|
|
|
|
await verifyQueueCap();
|
|
await verifyExtractionStoresMetadataOnly();
|
|
await verifyLegacySourceIsPrunedOnDueRead();
|
|
await verifyExpiryTransitionsAndStripsLegacySource();
|
|
console.log("OK");
|