Some checks failed
ClawSweeper Dispatch / dispatch (push) Has been cancelled
CodeQL / Security High (actions) (push) Has been cancelled
CodeQL / Security High (channel-runtime-boundary) (push) Has been cancelled
CodeQL / Security High (core-auth-secrets) (push) Has been cancelled
CodeQL / Security High (mcp-process-tool-boundary) (push) Has been cancelled
CodeQL / Security High (network-ssrf-boundary) (push) Has been cancelled
CodeQL / Security High (plugin-trust-boundary) (push) Has been cancelled
CodeQL / Security High (process-exec-boundary) (push) Has been cancelled
Docs Sync Publish Repo / sync-publish-repo (push) Has been cancelled
Docs / docs (push) Has been cancelled
OpenClaw Stable Main Closeout / Resolve stable release closeout inputs (push) Has been cancelled
OpenClaw Stable Main Closeout / Verify stable main closeout (push) Has been cancelled
Workflow Sanity / no-tabs (push) Has been cancelled
Workflow Sanity / actionlint (push) Has been cancelled
Workflow Sanity / generated-doc-baselines (push) Has been cancelled
CI / runner-admission (push) Has been cancelled
CI / preflight (push) Has been cancelled
CI / security-fast (push) Has been cancelled
CI / pnpm-store-warmup (push) Has been cancelled
CI / build-artifacts (push) Has been cancelled
CI / native-i18n (push) Has been cancelled
CI / ${{ matrix.check_name }} (push) Has been cancelled
CI / ${{ matrix.checkName }} (push) Has been cancelled
CI / checks-node-compat-node22 (push) Has been cancelled
CI / check-bundled-channel-config-metadata (push) Has been cancelled
CI / check-dependencies (push) Has been cancelled
CI / check-guards (push) Has been cancelled
CI / check-lint (push) Has been cancelled
CI / check-prod-types (push) Has been cancelled
CI / check-shrinkwrap (push) Has been cancelled
CI / check-test-types (push) Has been cancelled
CI / check-additional-boundaries-a (push) Has been cancelled
CI / check-additional-boundaries-bcd (push) Has been cancelled
CI / check-additional-extension-bundled (push) Has been cancelled
CI / check-additional-extension-channels (push) Has been cancelled
CI / check-additional-extension-package-boundary (push) Has been cancelled
CI / check-additional-runtime-topology-architecture (push) Has been cancelled
CI / check-session-accessor-boundary (push) Has been cancelled
CI / check-session-transcript-reader-boundary (push) Has been cancelled
CI / check-docs (push) Has been cancelled
CI / skills-python (push) Has been cancelled
CI / macos-swift (push) Has been cancelled
CI / ios-build (push) Has been cancelled
CI / ci-timings-summary (push) Has been cancelled
Native App Locale Refresh / Refresh native fa (push) Has been cancelled
Native App Locale Refresh / Refresh native fr (push) Has been cancelled
Native App Locale Refresh / Refresh native hi (push) Has been cancelled
Native App Locale Refresh / Refresh native id (push) Has been cancelled
Native App Locale Refresh / Refresh native it (push) Has been cancelled
Native App Locale Refresh / Refresh native ja-JP (push) Has been cancelled
Control UI Locale Refresh / plan (push) Has been cancelled
Control UI Locale Refresh / Refresh ${{ matrix.locale }} (push) Has been cancelled
Control UI Locale Refresh / Commit control UI locale refresh (push) Has been cancelled
Live Media Runner Image / Build live media runner image (push) Has been cancelled
Native App Locale Refresh / Refresh native ar (push) Has been cancelled
Native App Locale Refresh / Refresh native de (push) Has been cancelled
Native App Locale Refresh / Refresh native es (push) Has been cancelled
Native App Locale Refresh / Refresh native ko (push) Has been cancelled
Native App Locale Refresh / Refresh native nl (push) Has been cancelled
Native App Locale Refresh / Refresh native pl (push) Has been cancelled
Native App Locale Refresh / Refresh native pt-BR (push) Has been cancelled
Native App Locale Refresh / Refresh native ru (push) Has been cancelled
Native App Locale Refresh / Refresh native sv (push) Has been cancelled
Native App Locale Refresh / Refresh native th (push) Has been cancelled
Native App Locale Refresh / Refresh native tr (push) Has been cancelled
Native App Locale Refresh / Refresh native uk (push) Has been cancelled
Native App Locale Refresh / Refresh native vi (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-CN (push) Has been cancelled
Native App Locale Refresh / Refresh native zh-TW (push) Has been cancelled
Native App Locale Refresh / Commit native locale refresh (push) Has been cancelled
Plugin Init Scaffold Validation / Validate provider scaffold (push) Has been cancelled
Plugin NPM Release / preview_plugins_npm (push) Has been cancelled
Plugin NPM Release / Validate release publish approval (push) Has been cancelled
Plugin NPM Release / preview_plugin_pack (push) Has been cancelled
Plugin NPM Release / publish_plugins_npm (push) Has been cancelled
Sandbox Common Smoke / sandbox-common-smoke (push) Has been cancelled
Website Installer Sync / static (push) Has been cancelled
Website Installer Sync / linux-docker (push) Has been cancelled
Website Installer Sync / macos-installer (push) Has been cancelled
Website Installer Sync / windows-installer (push) Has been cancelled
Website Installer Sync / sync-website (push) Has been cancelled
Adolf is a fork/vendored clone of github.com/openclaw/openclaw (v2026.6.11), free to diverge. Tree copied sans upstream .git; upstream remote added for future syncs. Node pinned to 24 (.nvmrc); engines already require >=22.19. Preserves docs/ARCHITECTURE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeqyaxJF2nbRXJtae2kNB2
262 lines
8.0 KiB
TypeScript
262 lines
8.0 KiB
TypeScript
// Signal tests cover monitor.tool result.autostart plugin behavior.
|
|
import type { OpenClawConfig } from "openclaw/plugin-sdk/config-contracts";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import type { SignalDaemonExitEvent } from "./daemon.js";
|
|
import {
|
|
createSignalToolResultConfig,
|
|
createMockSignalDaemonHandle,
|
|
config,
|
|
getSignalToolResultTestMocks,
|
|
installSignalToolResultTestHooks,
|
|
setSignalToolResultTestConfig,
|
|
} from "./monitor.tool-result.test-harness.js";
|
|
|
|
installSignalToolResultTestHooks();
|
|
|
|
const { monitorSignalProvider } = await import("./monitor.js");
|
|
|
|
const { waitForTransportReadyMock, spawnSignalDaemonMock, streamMock } =
|
|
getSignalToolResultTestMocks();
|
|
|
|
const SIGNAL_BASE_URL = "http://127.0.0.1:8080";
|
|
type MonitorSignalProviderOptions = NonNullable<Parameters<typeof monitorSignalProvider>[0]>;
|
|
|
|
function createMonitorRuntime() {
|
|
return {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: ((code: number): never => {
|
|
throw new Error(`exit ${code}`);
|
|
}) as (code: number) => never,
|
|
};
|
|
}
|
|
|
|
function setSignalAutoStartConfig(overrides: Record<string, unknown> = {}) {
|
|
setSignalToolResultTestConfig(createSignalToolResultConfig(overrides));
|
|
}
|
|
|
|
function createAutoAbortController() {
|
|
const abortController = new AbortController();
|
|
streamMock.mockImplementation(async () => {
|
|
abortController.abort();
|
|
});
|
|
return abortController;
|
|
}
|
|
|
|
async function runMonitorWithMocks(opts: MonitorSignalProviderOptions) {
|
|
return monitorSignalProvider({
|
|
config: config as OpenClawConfig,
|
|
waitForTransportReady:
|
|
waitForTransportReadyMock as MonitorSignalProviderOptions["waitForTransportReady"],
|
|
...opts,
|
|
});
|
|
}
|
|
|
|
function requireWaitForTransportReadyOptions(): Record<string, unknown> {
|
|
const [call] = waitForTransportReadyMock.mock.calls;
|
|
if (!call) {
|
|
throw new Error("expected waitForTransportReady call");
|
|
}
|
|
const [options] = call;
|
|
if (!options || typeof options !== "object" || Array.isArray(options)) {
|
|
throw new Error("expected waitForTransportReady options");
|
|
}
|
|
return options as Record<string, unknown>;
|
|
}
|
|
|
|
function expectWaitForTransportReadyTimeout(timeoutMs: number) {
|
|
expect(waitForTransportReadyMock).toHaveBeenCalledTimes(1);
|
|
const options = requireWaitForTransportReadyOptions();
|
|
expect(options.timeoutMs).toBe(timeoutMs);
|
|
}
|
|
|
|
describe("monitorSignalProvider autostart", () => {
|
|
it("uses bounded readiness checks when auto-starting the daemon", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig();
|
|
const abortController = createAutoAbortController();
|
|
await runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
abortSignal: abortController.signal,
|
|
runtime,
|
|
});
|
|
|
|
expect(waitForTransportReadyMock).toHaveBeenCalledTimes(1);
|
|
const options = requireWaitForTransportReadyOptions();
|
|
expect(options).toEqual({
|
|
label: "signal daemon",
|
|
timeoutMs: 30_000,
|
|
logAfterMs: 10_000,
|
|
logIntervalMs: 10_000,
|
|
pollIntervalMs: 150,
|
|
runtime,
|
|
abortSignal: options.abortSignal,
|
|
check: options.check,
|
|
});
|
|
expect(options.abortSignal).toBeInstanceOf(AbortSignal);
|
|
expect(typeof options.check).toBe("function");
|
|
});
|
|
|
|
it("uses startupTimeoutMs override when provided", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig({ startupTimeoutMs: 60_000 });
|
|
const abortController = createAutoAbortController();
|
|
|
|
await runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
abortSignal: abortController.signal,
|
|
runtime,
|
|
startupTimeoutMs: 90_000,
|
|
});
|
|
|
|
expectWaitForTransportReadyTimeout(90_000);
|
|
});
|
|
|
|
it("passes channels.signal.configPath to signal-cli daemon startup", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig({ configPath: "~/.openclaw/signal-cli" });
|
|
const abortController = createAutoAbortController();
|
|
|
|
await runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
abortSignal: abortController.signal,
|
|
runtime,
|
|
});
|
|
|
|
expect(spawnSignalDaemonMock).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
configPath: "~/.openclaw/signal-cli",
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("omits configPath when channels.signal.configPath is blank", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig({ configPath: " " });
|
|
const abortController = createAutoAbortController();
|
|
|
|
await runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
abortSignal: abortController.signal,
|
|
runtime,
|
|
});
|
|
|
|
const [daemonOpts] = spawnSignalDaemonMock.mock.calls[0] ?? [];
|
|
expect(daemonOpts).toBeDefined();
|
|
expect(daemonOpts).not.toHaveProperty("configPath");
|
|
});
|
|
|
|
it("caps startupTimeoutMs at 2 minutes", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig({ startupTimeoutMs: 180_000 });
|
|
const abortController = createAutoAbortController();
|
|
|
|
await runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
abortSignal: abortController.signal,
|
|
runtime,
|
|
});
|
|
|
|
expectWaitForTransportReadyTimeout(120_000);
|
|
});
|
|
|
|
it("fails fast when auto-started signal daemon exits during startup", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig();
|
|
spawnSignalDaemonMock.mockReturnValueOnce(
|
|
createMockSignalDaemonHandle({
|
|
exited: Promise.resolve({ source: "process", code: 1, signal: null }),
|
|
isExited: () => true,
|
|
}),
|
|
);
|
|
waitForTransportReadyMock.mockImplementationOnce(
|
|
async (params: { abortSignal?: AbortSignal | null }) => {
|
|
await new Promise<void>((_resolve, reject) => {
|
|
if (params.abortSignal?.aborted) {
|
|
reject(toLintErrorObject(params.abortSignal.reason, "Non-Error rejection"));
|
|
return;
|
|
}
|
|
params.abortSignal?.addEventListener(
|
|
"abort",
|
|
() =>
|
|
reject(
|
|
toLintErrorObject(
|
|
params.abortSignal?.reason ?? new Error("aborted"),
|
|
"Non-Error rejection",
|
|
),
|
|
),
|
|
{ once: true },
|
|
);
|
|
});
|
|
},
|
|
);
|
|
|
|
await expect(
|
|
runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
runtime,
|
|
}),
|
|
).rejects.toThrow(/signal daemon exited/i);
|
|
});
|
|
|
|
it("treats daemon exit after user abort as clean shutdown", async () => {
|
|
const runtime = createMonitorRuntime();
|
|
setSignalAutoStartConfig();
|
|
const abortController = new AbortController();
|
|
let exited = false;
|
|
let resolveExit: ((value: SignalDaemonExitEvent) => void) | undefined;
|
|
const exitedPromise = new Promise<SignalDaemonExitEvent>((resolve) => {
|
|
resolveExit = resolve;
|
|
});
|
|
const stop = vi.fn(() => {
|
|
if (exited) {
|
|
return;
|
|
}
|
|
exited = true;
|
|
if (!resolveExit) {
|
|
throw new Error("Expected signal daemon exit resolver to be initialized");
|
|
}
|
|
resolveExit({ source: "process", code: null, signal: "SIGTERM" });
|
|
});
|
|
spawnSignalDaemonMock.mockReturnValueOnce(
|
|
createMockSignalDaemonHandle({
|
|
stop,
|
|
exited: exitedPromise,
|
|
isExited: () => exited,
|
|
}),
|
|
);
|
|
streamMock.mockImplementationOnce(async () => {
|
|
abortController.abort(new Error("stop"));
|
|
});
|
|
|
|
await expect(
|
|
runMonitorWithMocks({
|
|
autoStart: true,
|
|
baseUrl: SIGNAL_BASE_URL,
|
|
runtime,
|
|
abortSignal: abortController.signal,
|
|
}),
|
|
).resolves.toBeUndefined();
|
|
});
|
|
});
|
|
|
|
function toLintErrorObject(value: unknown, fallbackMessage: string): Error {
|
|
if (value instanceof Error) {
|
|
return value;
|
|
}
|
|
if (typeof value === "string") {
|
|
return new Error(value);
|
|
}
|
|
const error = new Error(fallbackMessage, { cause: value });
|
|
if ((typeof value === "object" && value !== null) || typeof value === "function") {
|
|
Object.assign(error, value);
|
|
}
|
|
return error;
|
|
}
|