"""
Unit tests for ml/serving — feature building and scoring contract.
Run with: pytest ml/serving/tests/
"""
import math
import pytest
from httpx import AsyncClient, ASGITransport

from main import (
    app,
    build_feature_vector,
    build_feature_vector_12,
    _norm_dwell,
    _norm_preferred_hour,
    _norm_rate,
    _norm_volume,
)


class TestFeatureVector:
    def test_shape(self):
        v = build_feature_vector({"hour_of_day": 8, "is_overdue": True, "task_age_days": 3, "priority": 3})
        assert v.shape == (5,)

    def test_hour_encoding_noon(self):
        v = build_feature_vector({"hour_of_day": 12})
        # sin(2π * 12/24) = sin(π) ≈ 0
        assert abs(v[0]) < 1e-10
        # cos(2π * 12/24) = cos(π) = -1
        assert abs(v[1] - (-1.0)) < 1e-10

    def test_hour_encoding_midnight(self):
        v = build_feature_vector({"hour_of_day": 0})
        # sin(0) = 0
        assert abs(v[0]) < 1e-10
        # cos(0) = 1
        assert abs(v[1] - 1.0) < 1e-10

    def test_hour_encoding_6am(self):
        v = build_feature_vector({"hour_of_day": 6})
        # sin(2π * 6/24) = sin(π/2) = 1
        assert abs(v[0] - 1.0) < 1e-10
        # cos(π/2) = 0
        assert abs(v[1]) < 1e-10

    def test_age_clipped_at_30(self):
        v_long = build_feature_vector({"task_age_days": 100})
        v_cap = build_feature_vector({"task_age_days": 30})
        assert v_long[3] == v_cap[3] == 1.0

    def test_age_zero(self):
        v = build_feature_vector({"task_age_days": 0})
        assert v[3] == pytest.approx(0.0)

    def test_age_15_days_normalised(self):
        v = build_feature_vector({"task_age_days": 15})
        assert v[3] == pytest.approx(0.5)

    def test_priority_normalised(self):
        v1 = build_feature_vector({"priority": 1})
        v4 = build_feature_vector({"priority": 4})
        assert v1[4] == pytest.approx(0.0)
        assert v4[4] == pytest.approx(1.0)

    def test_priority_2_and_3(self):
        v2 = build_feature_vector({"priority": 2})
        v3 = build_feature_vector({"priority": 3})
        assert v2[4] == pytest.approx(1 / 3)
        assert v3[4] == pytest.approx(2 / 3)

    def test_is_overdue_true(self):
        v = build_feature_vector({"is_overdue": True})
        assert v[2] == 1.0

    def test_is_overdue_false(self):
        v = build_feature_vector({"is_overdue": False})
        assert v[2] == 0.0

    def test_defaults_when_no_keys(self):
        v = build_feature_vector({})
        # hour=12 → sin(π)≈0, cos(π)=-1
        assert abs(v[0]) < 1e-10
        assert abs(v[1] - (-1.0)) < 1e-10
        assert v[2] == 0.0   # is_overdue=False
        assert v[3] == 0.0   # task_age_days=0
        assert v[4] == 0.0   # priority=1 → (1-1)/3=0


@pytest.mark.asyncio
async def test_health():
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.get("/health")
    assert r.status_code == 200
    assert r.json()["ok"] is True


@pytest.mark.asyncio
async def test_score_returns_a_candidate():
    payload = {
        "user_id": "test-user",
        "candidates": [
            {"id": "t:1", "content": "Task A", "source": "todoist", "source_id": "1",
             "features": {"is_overdue": True, "task_age_days": 2, "priority": 3}},
            {"id": "t:2", "content": "Task B", "source": "todoist", "source_id": "2",
             "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
        ],
        "context": {"hour_of_day": 9, "day_of_week": 1},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/score", json=payload)
    assert r.status_code == 200
    body = r.json()
    assert body["tip_id"] in {"t:1", "t:2"}
    assert "policy" in body
    assert body["policy"] == "linucb-v1"
    assert isinstance(body["score"], float)


@pytest.mark.asyncio
async def test_score_single_candidate_always_selected():
    """With a single candidate there is no choice — it must be returned."""
    payload = {
        "user_id": "solo-user",
        "candidates": [
            {"id": "only:1", "content": "Only task", "source": "todoist",
             "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
        ],
        "context": {"hour_of_day": 10, "day_of_week": 0},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/score", json=payload)
    assert r.status_code == 200
    assert r.json()["tip_id"] == "only:1"


@pytest.mark.asyncio
async def test_score_empty_candidates_returns_422():
    payload = {"user_id": "u", "candidates": [], "context": {"hour_of_day": 9, "day_of_week": 1}}
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/score", json=payload)
    assert r.status_code == 422


@pytest.mark.asyncio
async def test_reward_accepted():
    payload = {
        "user_id": "reward-user",
        "tip_id": "t:1",
        "reward": 1.0,
        "features": {"hour_of_day": 9, "is_overdue": True, "task_age_days": 2, "priority": 3},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/reward", json=payload)
    assert r.status_code == 200
    assert r.json()["ok"] is True


@pytest.mark.asyncio
async def test_reward_updates_stats():
    """Posting a reward should increase cumulative_reward in /stats."""
    user_id = "reward-stats-user"
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r0 = await client.get(f"/stats/{user_id}")
        before = r0.json()["cumulative_reward"]

        await client.post("/reward", json={
            "user_id": user_id,
            "tip_id": "tip:x",
            "reward": 1.0,
            "features": {"hour_of_day": 8, "is_overdue": False, "task_age_days": 0, "priority": 2},
        })
        r1 = await client.get(f"/stats/{user_id}")
    assert r1.json()["cumulative_reward"] == pytest.approx(before + 1.0)


@pytest.mark.asyncio
async def test_score_increments_pulls():
    user_id = "pull-counter-user"
    payload = {
        "user_id": user_id,
        "candidates": [
            {"id": "t:p1", "content": "Pull task", "source": "todoist",
             "features": {"is_overdue": False, "task_age_days": 1, "priority": 2}},
        ],
        "context": {"hour_of_day": 10, "day_of_week": 2},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r0 = await client.get(f"/stats/{user_id}")
        pulls_before = r0.json()["pulls"]

        await client.post("/score", json=payload)
        await client.post("/score", json=payload)

        r1 = await client.get(f"/stats/{user_id}")
    assert r1.json()["pulls"] == pulls_before + 2


@pytest.mark.asyncio
async def test_reset_clears_state():
    user_id = "reset-user"
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        # Score once to build state
        await client.post("/score", json={
            "user_id": user_id,
            "candidates": [
                {"id": "t:r", "content": "Reset task", "source": "todoist",
                 "features": {"is_overdue": True, "task_age_days": 5, "priority": 4}},
            ],
            "context": {"hour_of_day": 14, "day_of_week": 3},
        })
        r_reset = await client.post(f"/reset/{user_id}")
        assert r_reset.json()["ok"] is True

        r_stats = await client.get(f"/stats/{user_id}")
    assert r_stats.json()["pulls"] == 0


@pytest.mark.asyncio
async def test_features_endpoint_returns_history():
    user_id = "features-user"
    payload = {
        "user_id": user_id,
        "candidates": [
            {"id": "t:f1", "content": "Feature task", "source": "todoist",
             "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
        ],
        "context": {"hour_of_day": 7, "day_of_week": 0},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        await client.post("/score", json=payload)
        r = await client.get(f"/features/{user_id}")
    body = r.json()
    assert r.status_code == 200
    assert "history" in body
    assert len(body["history"]) >= 1
    entry = body["history"][-1]
    assert "ts" in entry
    assert "score" in entry
    assert "tip_id" in entry


@pytest.mark.asyncio
async def test_stats_for_fresh_user():
    """A user with no history should return zero/default stats without error."""
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.get("/stats/brand-new-user-xyz-abc")
    body = r.json()
    assert r.status_code == 200
    assert body["pulls"] == 0
    assert body["cumulative_reward"] == 0.0
    assert body["estimated_mean_reward"] == 0.0


class TestV2Normalization:
    def test_rate_passthrough(self):
        assert _norm_rate(0.0) == 0.0
        assert _norm_rate(0.42) == 0.42
        assert _norm_rate(1.0) == 1.0

    def test_rate_none_zero(self):
        assert _norm_rate(None) == 0.0

    def test_rate_clipped(self):
        assert _norm_rate(1.5) == 1.0
        assert _norm_rate(-0.1) == 0.0

    def test_dwell_none_zero(self):
        assert _norm_dwell(None) == 0.0

    def test_dwell_scales_to_0_1(self):
        assert _norm_dwell(0) == 0.0
        # 600_000 ms (10 min) is the clip ceiling
        assert _norm_dwell(600_000) == 1.0
        assert _norm_dwell(1_200_000) == 1.0
        assert _norm_dwell(60_000) == pytest.approx(0.1)

    def test_volume_monotonic_and_clipped(self):
        assert _norm_volume(None) == 0.0
        assert _norm_volume(0) == 0.0
        assert _norm_volume(10) < _norm_volume(100)
        # 100 tips ≈ full saturation
        assert _norm_volume(100) == pytest.approx(1.0)
        assert _norm_volume(10_000) == 1.0

    def test_preferred_hour_alignment(self):
        # Exact match → 1.0
        assert _norm_preferred_hour(9, 9) == pytest.approx(1.0)
        # 12h opposite → 0.0
        assert _norm_preferred_hour(21, 9) == pytest.approx(0.0, abs=1e-10)
        # 6h off → 0.5 (cos(π/2) = 0, scaled to 0.5)
        assert _norm_preferred_hour(15, 9) == pytest.approx(0.5, abs=1e-10)

    def test_preferred_hour_null_neutral(self):
        # Null preference → neutral 0.5 rather than misleading "alignment at 0"
        assert _norm_preferred_hour(None, 9) == 0.5


class TestFeatureVector12:
    def test_shape(self):
        v = build_feature_vector_12(
            {"hour_of_day": 9, "is_overdue": True, "task_age_days": 2, "priority": 3},
            day_of_week=2,
            profile={
                "completion_rate_30d": 0.5,
                "dismiss_rate_30d": 0.1,
                "mean_dwell_ms_30d": 60_000,
                "preferred_hour": 9,
                "tip_volume_30d": 20,
            },
        )
        assert v.shape == (12,)

    def test_first_seven_match_v1(self):
        """v2 must reduce to v1-style features on the first 7 dims so rollout
        behaviour is predictable when profile is absent."""
        from main import build_feature_vector_7
        feat = {"hour_of_day": 14, "is_overdue": True, "task_age_days": 5, "priority": 2}
        v1 = build_feature_vector_7(feat, day_of_week=3)
        v2 = build_feature_vector_12(feat, day_of_week=3, profile=None)
        assert (v1 == v2[:7]).all()

    def test_missing_profile_defaults(self):
        v = build_feature_vector_12({"hour_of_day": 9}, day_of_week=0, profile=None)
        # completion, dismiss, dwell, volume → 0; preferred_hour → 0.5 neutral
        assert v[7] == 0.0
        assert v[8] == 0.0
        assert v[9] == 0.0
        assert v[10] == pytest.approx(0.5)
        assert v[11] == 0.0


@pytest.mark.asyncio
async def test_score_egreedy_v2_returns_candidate():
    payload = {
        "user_id": "v2-user",
        "candidates": [
            {"id": "t:a", "content": "A", "source": "todoist",
             "features": {"is_overdue": True, "task_age_days": 2, "priority": 3}},
            {"id": "t:b", "content": "B", "source": "todoist",
             "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
        ],
        "context": {"hour_of_day": 9, "day_of_week": 1},
        "profile_features": {
            "completion_rate_30d": 0.4,
            "dismiss_rate_30d": 0.1,
            "mean_dwell_ms_30d": 45_000,
            "preferred_hour": 9,
            "tip_volume_30d": 8,
        },
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/score/egreedy/v2", json=payload)
    assert r.status_code == 200
    body = r.json()
    assert body["tip_id"] in {"t:a", "t:b"}
    assert body["policy"] == "egreedy-v2"


@pytest.mark.asyncio
async def test_score_egreedy_v2_accepts_missing_profile():
    payload = {
        "user_id": "v2-no-profile",
        "candidates": [
            {"id": "t:solo", "content": "Solo", "source": "todoist",
             "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
        ],
        "context": {"hour_of_day": 10, "day_of_week": 0},
    }
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r = await client.post("/score/egreedy/v2", json=payload)
    assert r.status_code == 200
    assert r.json()["tip_id"] == "t:solo"


@pytest.mark.asyncio
async def test_reward_egreedy_v2_updates_stats():
    user_id = "v2-reward-stats"
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r0 = await client.get(f"/stats/egreedy/v2/{user_id}")
        before = r0.json()["cumulative_reward"]

        await client.post("/reward/egreedy/v2", json={
            "user_id": user_id,
            "tip_id": "t:r",
            "reward": 1.0,
            "features": {"hour_of_day": 9, "is_overdue": True, "task_age_days": 2, "priority": 3},
            "day_of_week": 1,
            "profile_features": {
                "completion_rate_30d": 0.3,
                "dismiss_rate_30d": 0.2,
                "mean_dwell_ms_30d": 30_000,
                "preferred_hour": 9,
                "tip_volume_30d": 5,
            },
        })
        r1 = await client.get(f"/stats/egreedy/v2/{user_id}")
    body = r1.json()
    assert body["cumulative_reward"] == pytest.approx(before + 1.0)
    assert body["policy"] == "egreedy-v2"
    assert len(body["theta"]) == 12
    assert len(body["feature_labels"]) == 12


@pytest.mark.asyncio
async def test_reset_clears_v2_state():
    user_id = "v2-reset"
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        await client.post("/score/egreedy/v2", json={
            "user_id": user_id,
            "candidates": [
                {"id": "t:v2r", "content": "x", "source": "todoist",
                 "features": {"is_overdue": False, "task_age_days": 0, "priority": 1}},
            ],
            "context": {"hour_of_day": 10, "day_of_week": 0},
        })
        r0 = await client.get(f"/stats/egreedy/v2/{user_id}")
        assert r0.json()["pulls"] >= 1

        await client.post(f"/reset/{user_id}")
        r1 = await client.get(f"/stats/egreedy/v2/{user_id}")
    assert r1.json()["pulls"] == 0


@pytest.mark.asyncio
async def test_reward_negative_value():
    """Dismissing a tip should decrease cumulative_reward."""
    user_id = "dismiss-user-neg"
    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client:
        r0 = await client.get(f"/stats/{user_id}")
        before = r0.json()["cumulative_reward"]

        await client.post("/reward", json={
            "user_id": user_id,
            "tip_id": "t:neg",
            "reward": -1.0,
            "features": {"hour_of_day": 20, "is_overdue": False, "task_age_days": 0, "priority": 1},
        })
        r1 = await client.get(f"/stats/{user_id}")
    assert r1.json()["cumulative_reward"] == pytest.approx(before - 1.0)